Bump .ruby_version to latest Ruby version (3.3.5) #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosa
requested changes
Nov 11, 2024
README.md
Outdated
| @@ -252,7 +252,7 @@ class MyJob < ApplicationJob | |||
|
|
|||
| # ... | |||
| ``` | |||
| - `key` is the only required parameter, and it can be a symbol, a string or a proc that receives the job arguments as parameters and will be used to identify the jobs that need to be limited together. If the proc returns an Active Record record, the key will be built from its class name and `id`. | |||
| - `key` is the only required parameter, and it can be a symbol, a string or a proc that receives the job arguments as parameters and will be used to identify the jobs that need to be limited together. If the proc returns an ActiveRecord record, the key will be built from its class name and `id`. | |||
There was a problem hiding this comment.
I think Active Record is written separate 🤔 Unless it's the specific Ruby module, but in that case I think I'd have written ActiveRecord::Base.
There was a problem hiding this comment.
Thanks for the review, that makes sense. I wrongly thought it was referred to the module. Corrected.
berkos
force-pushed
the
berkos/bump-to-latest-ruby-version
branch
from
55da496
to
718fdc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Thanks for the review in advance. 🙏
This PR matches locally the ruby version with the CI .
Also corrects a couple of minor typos spotted while going through the Readme.