Simplify ready execution claiming, passing only job_ids #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need to pass executions, as that was a change to prepare for an implementation of sequential jobs that I won't be pursuing. We can simply pluck the job_ids of the selected executions, which as a side-effect, avoids an extra query due to counting the jobs before actually trying to claim them. Thanks to @djmb for spotting the extra `exists?` query that was a consequence of this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to pass executions, as that was a change to prepare for an implementation of sequential jobs that I won't be pursuing. We can simply pluck the
job_idsof the selected executions, which, as a side-effect, avoids an extra query due to counting the jobs before actually trying to claim them.Thanks to @djmb for spotting the extra
exists?query that was a consequence of this change.