Fix queue order when combining multiple prefixes or prefixes and names #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosa
force-pushed
the
fix-queue-selection
branch
from
9225ec5
to
92a8893
Compare
Separate `queue` database and bin/jobs to start. Also, refresh setup script to support `docker compose` and set up the 3 DBs.
Since we'll use separate DBs for test, there's no need to run all tests with a separate connection.
We were altering the original order to be exact names and then prefixes in the order returned by the DB, which doesn't need to be the order specified for the worker. This change ensures the order is respected.
rosa
force-pushed
the
fix-queue-selection
branch
from
92a8893
to
6276b4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were altering the original order to be exact names and then prefixes in the order returned by the DB, which doesn't need to be the order specified for the worker. This change ensures the order is respected. Besides this, this also documents a bit the performance implications of the different ways to specify queues per worker.
This fixes #360.