Skip to content

Fix watcher test for Ruby 3 #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Sixeight
Copy link
Contributor

@Sixeight Sixeight commented Oct 24, 2020

before after
image image

Why

What

  • Use keyword argument instead of Has as optional argument
    • FileUtils.touch accepts keyword argument since Ruby 2.4 (commit)
    • Spring supports Ruby 2.4 over.

Other fails

  • Acceptance test fails on undef Rais 5.1
  • Environment setup fails on Ruby 2.4.x
    • sprockets requires Ruby version >= 2.5.0. The current ruby version is 2.4.6.354.
    • Officially support Ruby 2.4.x ?
  • Environment set fails on Rails 5.2 with Ruby 2
    • /home/travis/.rvm/gems/ruby-head/gems/activesupport-5.2.4.4/lib/active_support/messages/metadata.rb:17:in wrap': wrong number of arguments (given 2, expected 1) (ArgumentError)`
    • Maybe rails matter, should ignore this patter of test.

Related

@Sixeight Sixeight closed this Feb 10, 2021
@Sixeight Sixeight deleted the fix-test-for-ruby3 branch February 10, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant