WIP: pass functions directly #630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
approved these changes
Oct 19, 2019
|
sassc 2.3.0 has been released |
glebm
approved these changes
May 3, 2020
|
@ahorek I think we'd also need to replace the dependency on |
This was referenced Jun 9, 2020
Closed
|
is this ready to merge or still WIP? |
|
well, since sassc 2.3 is out for 6 months, there's nothing else blocking this PR. however, it's difficult to write a reliable test case for it. It would require concurrent access to sass template that includes url helpers. sass/sassc-rails#148 might be an alternative, but I didn't test it by myself. |
|
closing this, because it seems to be resolved by a slightly alternative approach #759 .... after 3 years, ouch... :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this attempts to fix a problem with thread safety, see #581 for more context
fixes #633 sass/sassc-ruby#133 sass/sassc-rails#122 sass/sassc-rails#58 #638 ...
there's a race condition between sassc_processor.rb and sassc_compressor.rb, both calls SassC::Engine with different functions.
WIP because it this depends on sass/sassc-ruby#162
1/ no more segfaults even with concurrency enabled
2/ sass gem has the same problem, but the gem is deprecated, so it can't be fixed
3/ https://github.com/sass/sassc-rails will require a similar change