Improve detection of files already digested #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything else needed before this can be merged? Then we need to update jsbundling-rails to produce these outputs by default. Would be nice to turn on source maps for esbuild by default as well. |
brenogazzola
force-pushed
the
already-digested-fix
branch
from
888faf4
to
9e3d2df
Compare
|
Yes. I'll update the Webpack file in jsbundling to reflect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in rails/propshaft#10, the current auto detection of digests in the filename is causing false positives. So we are changing it to require the
.digestedword after the digest.To keep parity with Propshaft, and make this compatible with esbuild (which does not use any of sprockets digest algorithms), I've relaxed the regex and removed the digest class detection