rake task execution: test coverage and refactoring #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-better-command-execution
branch
3 times, most recently
from
f9eca84 to
978ae4c
Compare
primarily this is to exercise the rake tasks.
flavorjones
force-pushed
the
flavorjones-better-command-execution
branch
from
978ae4c to
a3f6e46
Compare
Note that this is a pretty heavy refactoring, where code was moved from `exe/tailwindcss` to `lib/tailwindcss/commands.rb` where we can more easily run unit tests on it. Note also that we no longer use Shellwords to build command strings, a library which does not generate correct strings on Windows platforms. Instead we consistently use arrays of command arguments, which can be passed to `exec` or `system` however we see fit. The wrapper script conditionally uses `system` on windows platforms because `exec` can't find the executable (see related issue at rubys/sprockets-esbuild#4). Finally, note that the rake tasks no longer use the `exe/tailwindcss` wrapper script, and instead use the binary executable directly. We can reverse this decision if we ever decide to support manually-installed tailwindcss somewhere on the $PATH; but because previously the rake tasks hardcoded the path/to/exe/tailwindcss, we're not introducing any new constraints by skipping the wrapper.
flavorjones
force-pushed
the
flavorjones-better-command-execution
branch
from
7ec496e to
653d214
Compare
This was referenced Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces CI pipeline test coverage for our documented user journey, which will exercise the rake tasks. It also closes #184.
After the first commit, we see the expected failure for #184:
Note that this is a pretty heavy refactoring, where code is being moved
from
exe/tailwindcsstolib/tailwindcss/commands.rbwhere we canmore easily run unit tests on it.
Note also that we no longer use Shellwords to build command strings, a
library which does not generate correct strings on Windows
platforms. Instead we consistently use arrays of command arguments,
which can be passed to
execorsystemhowever we see fit.The wrapper script conditionally uses
systemon windows platformsbecause
execcan't find the executable (see related issue atrubys/sprockets-esbuild#4).
Finally, note that the rake tasks no longer use the
exe/tailwindcsswrapper script, and instead use the binary executable directly. We can
reverse this decision if we ever decide to support manually-installed
tailwindcss somewhere on the $PATH; but because previously the rake
tasks hardcoded the path/to/exe/tailwindcss, we're not introducing any
new constraints by skipping the wrapper.