feat: support polling for watching files #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- distinguish content with subsection headings - highlight the rake tasks' attachments, which seem to be confusing for some folks - lead with installation, then get to the development mode content
Polling was added upstream in 3.1.0. Suggested by #168
flavorjones
force-pushed
the
flavorjones-allow-polling
branch
from
17ebb1c to
bf09205
Compare
This was referenced Sep 3, 2022
dhh
approved these changes
Sep 5, 2022
|
TIL about using rake task arguments like this! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polling was added upstream in 3.1.0 to solve timing issues with systems that don't fully support file system events (see tailwindlabs/tailwindcss#7725).
This builds on the commits at #198 to support a
pollargument to thetailwindcss:watchrake task:Because we're using rake task arguments, we can combine
pollwith thedebugargument from #198 like so:This PR supersedes #168