Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify bin/dev script with other js/css installers #219

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

marcoroth
Copy link
Contributor

In a similar manner to rails/dartsass-rails#35.

This Pull Request streamlines the content of the bin/dev script across rails/tailwindcss-rails, rails/dartsass-rails, rails/jsbundling-rails and rails/cssbundling-rails so you don't run into conflicts when running multiple installers:

❯ rails tailwindcss:install
Add Tailwindcss include tags and container element in application layout
    insert  app/views/layouts/application.html.erb

Build into app/assets/builds
    exist  app/assets/builds
    identical  app/assets/builds/.keep
    append  Procfile.dev

Add bin/dev to start foreman
    conflict  bin/dev

Overwrite /Users/marcoroth/Development/project/bin/dev? (enter "h" for help) [Ynaqdhm]

This PR applies the changes from rails/cssbundling-rails#93 and rails/cssbundling-rails#98

@flavorjones
Copy link
Member

This seems reasonable to me. I've pinged @rafaelfranca to make sure these PRs (this and the dartsass-rails PR) are merged or changed together.

@rafaelfranca rafaelfranca merged commit 203a01c into rails:main Nov 7, 2022
@marcoroth marcoroth deleted the unify-dev-script branch November 7, 2022 23:26
@flavorjones
Copy link
Member

I'll cut a release tomorrow with this change.

@flavorjones
Copy link
Member

Release v2.0.19 / 2022-11-08 · rails/tailwindcss-rails

@marcoroth
Copy link
Contributor Author

Thank you @flavorjones!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants