Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install as Puma plugin if available #331

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

javierav
Copy link

@javierav javierav commented Feb 8, 2024

This PR implements a first approach to resolve #327. The README remains to be updated if this solution is finally accepted.

@bruno- bruno- mentioned this pull request Apr 18, 2024
@flavorjones
Copy link
Member

Thank you for writing this up! It seems reasonable, but I do have a concern that we're doing a lot to try to guess (and then not break) the user's development workflow.

I have a slight preference for #347 which is more general, if we can figure out how to land it. Let's leave this open for now, but I'll circle back once we made a decision on the other PR.

@flavorjones
Copy link
Member

Circling back on this. The other PR was a good approach but DHH opined that it should be done in Rails (not in an individual asset gem like this).

This PR's change is much simpler, but a) running bin/dev will kick off two build watch processes (one by the Procfile and one by the Puma plugin), and b) it should arguably still be moved into Rails so that it's not living in individual asset gems.

WDYT? If you want to try to address (a) then we can discuss (b) with David.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants