Allow values to include hyphens when specified unambiguously with "=" #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
requested changes
Feb 13, 2017
| @@ -129,6 +134,7 @@ def check_unknown! | |||
| # Two booleans are returned. The first is true if the current value | |||
| # starts with a hyphen; the second is true if it is a registered switch. | |||
| def current_is_switch? | |||
| return false if @force_value | |||
There was a problem hiding this comment.
This should return an array.
| @@ -257,6 +257,7 @@ def remaining | |||
| expect(parse("-f=12")["foo"]).to eq("12") | |||
| expect(parse("--foo=12")["foo"]).to eq("12") | |||
| expect(parse("--foo=bar=baz")["foo"]).to eq("bar=baz") | |||
| expect(parse("--foo=-bar")["foo"]).to eq("-bar") | |||
There was a problem hiding this comment.
We need a test when there is more than one options.
| when EQ_RE | ||
| unshift($2) | ||
| switch = $1 | ||
| @force_value = true |
There was a problem hiding this comment.
I think setting this state here will broke it if there are more options after the first with - in the value, can you add tests to make sure it will work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈
I noticed that if an option value begins with a "-" (
/^-/), it will be parsed as a switch, even in cases likewhere it seems that the presence of the "=" allows the value (
-bar) to be unambiguously parsed as a value instead of a switch.The new spec expectation should be clear; I'm less confident in the implementation, as the current implementation relies quite a bit on several stateful instance variables.