Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require did_you_mean #640

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Do not require did_you_mean #640

merged 1 commit into from
Nov 15, 2018

Commits on Nov 15, 2018

  1. Do not require did_you_mean 

    This caused a drastic performance hit (100x slower) on our JRuby applications because it was requiring `did_you_mean` even though we have:

```
JRUBY_OPTS="--disable:did_you_mean"
```

set. In looking through other libraries that use `did_you_mean`, it looks like a fairly common pattern is to just check if the portions of `did_you_mean` that are needed are defined. I tried to replicate that in this patch.
    @quixoten
    quixoten committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    8c57f1d View commit details
    Browse the repository at this point in the history