Amend --skip-foo fix with a trailing option
#682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that the `current_is_option?` method properly matches its own documentation, and consistently returns a pair of booleans.
The fix in bdb43eb unintentioanlly dropped support for specifying things like `--skip-foo=f` or `--skip-foo true`. In the first case, for no good reason, in the second, because "true" is now interpreted as a command option, not as a flag. This commit restores support for those, so that arguments right after `--skip-foo` flags will never be interpreted as the flag's value, unless they are "true", "t", "false", or "f". So `my_program --skip-foo true` means "run my_program without arguments and the 'foo' flag unset". whereas `my_program --skip-foo asdf` means "run my_program with argument 'asdf' and the 'foo' flag unset"
deivid-rodriguez
changed the title
--skip-foo fix with a trailing option--skip-foo fix with a trailing option
deivid-rodriguez
deleted the
ammend_no_or_skip_with_trailing_option_fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in bdb43eb unintentioanlly dropped support for specifying things like
--skip-foo=for--skip-foo true. In the first case, for no good reason, in the second, because "true" is now interpreted as a command option, not as a flag.This PR restores support for those, so that arguments right after
--skip-fooflags will never be interpreted as the flag's value, unless they are "true", "t", "false", or "f".So
my_program --skip-foo truemeans
"run my_program without arguments and the 'foo' flag unset".
whereas
my_program --skip-foo asdfmeans
"run my_program with argument 'asdf' and the 'foo' flag unset".
By doing this, we still fix what #679 intended to fix, but still retain maximum backwards compatibility and flexibility.