Check if type: array values are in enum
#784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
reviewed
Apr 25, 2022
| array << shift while current_is_value? | ||
| while current_is_value? | ||
| value = shift | ||
| if !value.empty? && @switches.is_a?(Hash) && switch = @switches[name] |
There was a problem hiding this comment.
Can we restructure this conditional a bit? The = towards the end is kind of like a shark in calm waters, it's really unexpected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈
What are you trying to accomplish?
Fixes #783
What approach did you choose and why?
Extending the pattern done for
type: stringandtype: numeric.What should reviewers focus on?
🤷
The impact of these changes
enumvalidation will be done fortype: arrayoption values.