Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't document negative boolean option named no_* #797

Merged
merged 2 commits into from
May 11, 2023
Merged

Don't document negative boolean option named no_* #797

merged 2 commits into from
May 11, 2023

Conversation

BrentWheeldon
Copy link
Contributor

🌈

I ran into this earlier today where I had underscored option names. Let me know if there is anything else I should include! 🙇🏻

@dorner
Copy link

dorner commented Oct 26, 2022

@BrentWheeldon looks like this fails on some versions of Ruby!

@BrentWheeldon
Copy link
Contributor Author

@dorner Ah - I didn't realise that String#starts_with? only relatively recently started accepting a regex. Fixed!

@dorner
Copy link

dorner commented Oct 26, 2022

Nice, looks good to me! @rafaelfranca

@rafaelfranca rafaelfranca merged commit d7840bb into rails:main May 11, 2023
@BrentWheeldon BrentWheeldon deleted the BrentWheeldon/option-bug-fix branch May 11, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants