Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer to use URI.open and File.open instead of Kernel.open #802

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Prefer to use URI.open and File.open instead of Kernel.open #802

merged 3 commits into from
Feb 23, 2023

Conversation

hsbt
Copy link
Contributor

@hsbt hsbt commented Dec 13, 2022

👋 CodeQL detects "Use of Kernel.open or IO.read with a non-constant value" warnings in https://github.com/ruby/ruby. I hope to suppress them.

@deivid-rodriguez
Copy link
Contributor

I fixed the URI.open ones similarly at #787. Not yet attended unfortunately!

@hsbt
Copy link
Contributor Author

hsbt commented Dec 13, 2022

Oh! Thanks to share it.

@deivid-rodriguez
Copy link
Contributor

Should we enable Security/Open in RuboCop configuration file too?

@hsbt
Copy link
Contributor Author

hsbt commented Dec 15, 2022 •
edited
Loading

👍 or add CodeQL actions.

@deivid-rodriguez
Copy link
Contributor

That too, just thought of RuboCop since it's already used.

@rafaelfranca
Copy link
Member

Can you please rebase this PR?

@hsbt hsbt force-pushed the suppress-warning-codeql branch from 47d4a06 to c88f213 Compare February 9, 2023 01:40
@hsbt hsbt force-pushed the suppress-warning-codeql branch from c88f213 to 16db563 Compare February 9, 2023 01:51
@hsbt
Copy link
Contributor Author

hsbt commented Feb 9, 2023

@rafaelfranca done 🚀

@rafaelfranca rafaelfranca merged commit 2d69011 into rails:main Feb 23, 2023
@hsbt hsbt deleted the suppress-warning-codeql branch February 24, 2023 00:30
@hsbt
Copy link
Contributor Author

hsbt commented Feb 24, 2023

Thanks @rafaelfranca ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsbt @deivid-rodriguez @rafaelfranca