Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console not showing on error page #331

Closed
Ben-Owen-3183 opened this issue Aug 4, 2023 · 4 comments
Closed

Console not showing on error page #331

Ben-Owen-3183 opened this issue Aug 4, 2023 · 4 comments

Comments

@Ben-Owen-3183
Copy link

On newest master the error console does not show in the error page anymore.

No errros in browser console

No errors in rails terminal.
@rafaelfranca
Copy link
Member

This is probably because of Rack 3 incompatibilities. The console isn't rendered because it thinks the content-type isn't html.

@JoeDupuis
Copy link

JoeDupuis commented Aug 21, 2023 •
edited
Loading

It looks like this has been fixed already.

Switching my Gemfile to gem "web-console", github: "rails/web-console", branch: "main" brings it back.

Can we cut a release?

@rafaelfranca
Copy link
Member

That doesn't fix the issue. It actually make it worse since now that code doesn't work with Rack 2.x. That is the problem OP was talking about. With gem "web-console", github: "rails/web-console", branch: "master" on the gemfile of an existing Rails application, the console doesn't work anymore. So if I do a new release it will break existing applications.

@rafaelfranca rafaelfranca mentioned this issue Aug 21, 2023
Closed
@JoeDupuis
Copy link

JoeDupuis commented Aug 21, 2023 •
edited
Loading

Oh! My bad 😅 I misread and assumed OP had the same issue I had, running Rails edge with older console not the reverse.

I'll try to take a look at it this week if no one gets to it first.

JoeDupuis added a commit to JoeDupuis/web-console that referenced this issue Aug 22, 2023
@JoeDupuis
[FIX rails#331] Add simultaneous support for both Rack 2 and 3
ee6f0fe 
[rails#318] introduced a [regression](rails#331) for apps running Rack 2.
Rack 3 follows the http 2 spec and requires lowercase headers.
By using the Rack header constants we get the correct capitalization
regardless of which rack version is loaded.
@JoeDupuis JoeDupuis mentioned this issue Aug 22, 2023
Merged
JoeDupuis added a commit to JoeDupuis/web-console that referenced this issue Aug 22, 2023
@JoeDupuis
[FIX rails#331] Add simultaneous support for both Rack 2 and 3
1cc5bf0 
[rails#318] introduced a [regression](rails#331) for apps running Rack 2.
Rack 3 follows the http 2 spec and requires lowercase headers.
By using the Rack header constants we get the correct capitalization
regardless of which rack version is loaded.
gsamokovarov added a commit that referenced this issue Aug 24, 2023
@gsamokovarov
Merge pull request #332 from JoeDupuis/support-rack-2-and-3
8c1670f 
[FIX #331] Add simultaneous support for Rack 2 and 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rafaelfranca @JoeDupuis @Ben-Owen-3183