Skip to content

Enhancements for templates testing #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 20, 2016

Conversation

sh19910711
Copy link

This pull request includes some enhancements for templates testing.

  • Unify tests into the TDD style
  • Use already installed phantomjs if it exists
    • if not, then install it automatically from the npm registry
  • Use mocha-phantomjs-core instead of mocha-phantomjs
    • to use the latest version of phantomjs
  • Test key events of the auto completion feature

Thank you.

@rails-bot
Copy link

r? @gsamokovarov

(@rails-bot has picked a reviewer for you, use r? to override)

@gsamokovarov
Copy link
Collaborator

Thanks!

@gsamokovarov gsamokovarov merged commit 98b5f68 into rails:master Jul 20, 2016
mishina2228 added a commit to mishina2228/web-console that referenced this pull request May 24, 2022
`test/templates/spec` is removed at rails#211
mishina2228 added a commit to mishina2228/web-console that referenced this pull request Jun 8, 2022
`test/templates/spec` is removed at rails#211
mishina2228 added a commit to mishina2228/web-console that referenced this pull request Jun 9, 2022
`test/templates/spec` is removed at rails#211
patrickm68 added a commit to patrickm68/web-console that referenced this pull request Dec 1, 2022
`test/templates/spec` is removed at rails/web-console#211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants