Fix Content-Length for rack >= 2.1.0 #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
requested changes
May 28, 2020
lib/web_console/injector.rb
Outdated
| # the body. Otherwise the response will be truncated. | ||
| @headers.delete("Content-Length") | ||
| # Set Content-Length header to the size of the current body | ||
| # + the extra conent. Otherwise the response will be truncated. |
There was a problem hiding this comment.
Suggested change
| # + the extra conent. Otherwise the response will be truncated. | |
| # + the extra content. Otherwise the response will be truncated. |
Since rack 2.1.0 the Content-Length header is no longer updated for if the body argument isn't a string. This was done for performance reasons. It is recommended to set Content-Length header in the middlewate instead. rack/rack#1472 (comment)
mishina2228
added a commit
to mishina2228/web-console
that referenced
this pull request
Jun 8, 2022
Similar change as rails#290
mishina2228
added a commit
to mishina2228/web-console
that referenced
this pull request
Jun 9, 2022
Similar change as rails#290
Merged
patrickm68
added a commit
to patrickm68/web-console
that referenced
this pull request
Dec 1, 2022
Similar change as rails/web-console#290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rack 2.1.0 the Content-Length header is no longer updated for
if the body argument isn't a string. This was done for performance
reasons. It is recommended to set Content-Length header in the
middlewate instead.
See: rack/rack#1472 (comment)
This fixes the build.