Skip to content

Commit

Permalink
Don't generate integrity hash [fixes #1835]
Browse files Browse the repository at this point in the history
  • Loading branch information
@gauravtiwari
gauravtiwari committed Dec 15, 2018
1 parent 3aa4a5d commit 2110058
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package/environments/base.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const getPluginList = () => {
result.append(
'Manifest',
new WebpackAssetsManifest({
integrity: true,
integrity: false,
entrypoints: true,
writeToDisk: true,
publicPath: true
Expand Down

2 comments on commit 2110058

@justin808
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gauravtiwari What motivated this change? Yes, #1835, but can you say more?

@gauravtiwari
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 I was thinking to ship integrity support with 4.0 (#1823) but this option changed the structure of manifest.json, which wasn't compatible with the existing implementation. That's why disabled it since it makes sense to only enable it when we have proper support for integrity hashes merged in.

Obviously, we could have done some workaround but since this feature isn't supported at all it makes sense to just disable it for now.

Please sign in to comment.