Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn check deprecated #2354

Closed
albus522 opened this issue Nov 5, 2019 · 4 comments
Closed

yarn check deprecated #2354

albus522 opened this issue Nov 5, 2019 · 4 comments
Labels
bug dependencies dependency, yarn or other package management help wanted yarn 2.0

Comments

@albus522
Copy link

albus522 commented Nov 5, 2019

yarn check used here https://github.com/rails/webpacker/blob/master/lib/webpacker/railtie.rb#L33 is deprecated yarnpkg/rfcs#106

We ran into an issue in our project where yarn install worked fine but yarn check was reporting multiple errors. Searching for a solution lead here yarnpkg/yarn#6427 (comment) which lead to the merged deprecation.

@paulodeon
Copy link

I'd like to add that this has led to several wasted hours figuring this out - its especially problematic as that check command gets run on every rails command - it has even broken deploys for us

@rossta
Copy link
Member

rossta commented Jan 24, 2020

I suggest turning it off in your config/webpacker.yml if it's causing pain:

check_yarn_integrity: false

@challeng
Copy link

challeng commented Feb 7, 2020

yarn check is also called out as buggy(https://classic.yarnpkg.com/en/docs/cli/check/) in addition to being deprecated and removed in Yarn 2.0 which has had its first stable release. I found another issue in the repo too which calls out that this will need to change soon #2007.

Is there an alternative for verifying integrity? The best alternative I know about is yarn install --check-files, but adding that would add the install to this step. I thought about opening a PR to do that, but I wasn't sure if that particular change would go over well

@sfcgeorge
Copy link
Contributor

It's constantly causing issues for us now so I tried check_yarn_integrity: false in webpacker.yml (and restarted Spring) but it had no effect. Really slowing down development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies dependency, yarn or other package management help wanted yarn 2.0
Projects
None yet
Development

No branches or pull requests

7 participants