Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package.json engine semver ranges (node.js >=8.9 <13, yarn >=1 <2) #2454

Merged
merged 3 commits into from
Feb 10, 2020

Conversation

jbielick
Copy link
Contributor

8.16 is somewhat arbitrary as far as I can tell, so this allows earlier 8.x releases of node.js as the engine so that 8.9, 8.10, 8.12, etc from Ubuntu 18.04 LTS can install this package.

See #2228 comments for interest.

8.16 is somewhat arbitrary as far as I can tell, so this allows earlier 8.x releases of node.js as the engine so that 8.9, 8.10, 8.12, etc from Ubuntu 18.04 LTS can install this package.

rails#2228
Copy link
Member

@jakeNiemiec jakeNiemiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
jbielick and others added 2 commits February 10, 2020 13:28
Co-Authored-By: Jake Niemiec <jake.j.niemiec@gmail.com>
As 13 has been released, an upper limit is prudent as well.

Co-Authored-By: Jake Niemiec <jake.j.niemiec@gmail.com>
@jbielick
Copy link
Contributor Author

@jakeNiemiec Great idea—updated. Thanks for the additional references and suggestions.

@jakeNiemiec jakeNiemiec changed the title Allow node.js 8.9 engine compatibility Fix package.json engine semver ranges (node.js >=8.9 <13, yarn >=1 <2) Feb 10, 2020
@jakeNiemiec
Copy link
Member

Unless the user has set the engine-strict config flag, this field is advisory only and will only produce warnings when your package is installed as a dependency.

Something to keep in mind, but this sounds exactly like what we need.

@jakeNiemiec jakeNiemiec merged commit f3a107d into rails:master Feb 10, 2020
@jbielick jbielick deleted the patch-1 branch February 10, 2020 19:04
eileencodes added a commit that referenced this pull request Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants