-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package.json engine semver ranges (node.js >=8.9 <13, yarn >=1 <2) #2454
Conversation
8.16 is somewhat arbitrary as far as I can tell, so this allows earlier 8.x releases of node.js as the engine so that 8.9, 8.10, 8.12, etc from Ubuntu 18.04 LTS can install this package. rails#2228
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more justification for 8.9
https://github.com/webpack-contrib/terser-webpack-plugin/releases/tag/v2.0.0
https://github.com/webpack/webpack/blob/1af81690ffc79ccf051f74d15bcefddb7ad3b2c9/package.json#L84
https://github.com/webpack-contrib/compression-webpack-plugin/blob/master/package.json#L16
Thanks for the PR, can you expand your scope to also fix the yarn engine range? I have adjusted the ranges according to https://semver.npmjs.com/ (test here) & https://nodejs.org/en/about/releases/
Co-Authored-By: Jake Niemiec <jake.j.niemiec@gmail.com>
As 13 has been released, an upper limit is prudent as well. Co-Authored-By: Jake Niemiec <jake.j.niemiec@gmail.com>
@jakeNiemiec Great idea—updated. Thanks for the additional references and suggestions. |
Something to keep in mind, but this sounds exactly like what we need. |
8.16 is somewhat arbitrary as far as I can tell, so this allows earlier 8.x releases of node.js as the engine so that 8.9, 8.10, 8.12, etc from Ubuntu 18.04 LTS can install this package.
See #2228 comments for interest.