Skip to content

Allow commands to run via yarn #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions lib/webpacker/dev_server_runner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,22 @@ def detect_port!

def execute_cmd
env = Webpacker::Compiler.env
cmd = [
"#{@node_modules_bin_path}/webpack-dev-server",
"--config", @webpack_config
]

cmd = if node_modules_bin_exist?
["#{@node_modules_bin_path}/webpack-dev-server"]
else
["yarn", "webpack-dev-server"]
end
cmd += ["--config", @webpack_config]
cmd += ["--progress", "--color"] if @pretty

Dir.chdir(@app_path) do
exec env, *cmd
Kernel.exec env, *cmd
end
end

def node_modules_bin_exist?
File.exist?("#{@node_modules_bin_path}/webpack-dev-server")
end
end
end
15 changes: 13 additions & 2 deletions lib/webpacker/webpack_runner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,22 @@ module Webpacker
class WebpackRunner < Webpacker::Runner
def run
env = Webpacker::Compiler.env
cmd = [ "#{@node_modules_bin_path}/webpack", "--config", @webpack_config ] + @argv

cmd = if node_modules_bin_exist?
["#{@node_modules_bin_path}/webpack"]
else
["yarn", "webpack"]
end
cmd += ["--config", @webpack_config] + @argv

Dir.chdir(@app_path) do
exec env, *cmd
Kernel.exec env, *cmd
end
end

private
def node_modules_bin_exist?
File.exist?("#{@node_modules_bin_path}/webpack")
end
end
end
2 changes: 2 additions & 0 deletions test/compiler_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ def test_custom_environment_variables
assert Webpacker.compiler.send(:webpack_env)["FOO"] == nil
Webpacker.compiler.env["FOO"] = "BAR"
assert Webpacker.compiler.send(:webpack_env)["FOO"] == "BAR"
ensure
Webpacker.compiler.env = {}
end

def test_default_watched_paths
Expand Down
51 changes: 51 additions & 0 deletions test/dev_server_runner_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
require "test_helper"
require "webpacker/dev_server_runner"

class DevServerRunnerTest < Webpacker::Test
def setup
@original_node_env, ENV["NODE_ENV"] = ENV["NODE_ENV"], "development"
@original_rails_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "development"
end

def teardown
ENV["NODE_ENV"] = @original_node_env
ENV["RAILS_ENV"] = @original_rails_env
end

def test_run_cmd_via_node_modules
cmd = ["#{test_app_path}/node_modules/.bin/webpack-dev-server", "--config", "#{test_app_path}/config/webpack/development.js"]

verify_command(cmd, use_node_modules: true)
end

def test_run_cmd_via_yarn
cmd = ["yarn", "webpack-dev-server", "--config", "#{test_app_path}/config/webpack/development.js"]

verify_command(cmd, use_node_modules: false)
end

private
def test_app_path
File.expand_path("test_app", __dir__)
end

def verify_command(cmd, use_node_modules: true)
cwd = Dir.pwd
Dir.chdir(test_app_path)

klass = Webpacker::DevServerRunner
instance = klass.new([])
mock = Minitest::Mock.new
mock.expect(:call, nil, [{}, *cmd])

klass.stub(:new, instance) do
instance.stub(:node_modules_bin_exist?, use_node_modules) do
Kernel.stub(:exec, mock) { klass.run([]) }
end
end

mock.verify
ensure
Dir.chdir(cwd)
end
end
Empty file.
51 changes: 51 additions & 0 deletions test/webpack_runner_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
require "test_helper"
require "webpacker/webpack_runner"

class WebpackRunnerTest < Webpacker::Test
def setup
@original_node_env, ENV["NODE_ENV"] = ENV["NODE_ENV"], "development"
@original_rails_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "development"
end

def teardown
ENV["NODE_ENV"] = @original_node_env
ENV["RAILS_ENV"] = @original_rails_env
end

def test_run_cmd_via_node_modules
cmd = ["#{test_app_path}/node_modules/.bin/webpack", "--config", "#{test_app_path}/config/webpack/development.js"]

verify_command(cmd, use_node_modules: true)
end

def test_run_cmd_via_yarn
cmd = ["yarn", "webpack", "--config", "#{test_app_path}/config/webpack/development.js"]

verify_command(cmd, use_node_modules: false)
end

private
def test_app_path
File.expand_path("test_app", __dir__)
end

def verify_command(cmd, use_node_modules: true)
cwd = Dir.pwd
Dir.chdir(test_app_path)

klass = Webpacker::WebpackRunner
instance = klass.new([])
mock = Minitest::Mock.new
mock.expect(:call, nil, [{}, *cmd])

klass.stub(:new, instance) do
instance.stub(:node_modules_bin_exist?, use_node_modules) do
Kernel.stub(:exec, mock) { klass.run([]) }
end
end

mock.verify
ensure
Dir.chdir(cwd)
end
end