Refactor singleton usage and make it possible to use with engines #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/webpacker/helper.rb
Outdated
| # Returns current Webpacker instance. | ||
| # Could be overriden to use multiple Webpacker | ||
| # configurations within the same app (e.g. with engines) | ||
| def current_webpacker |
There was a problem hiding this comment.
Perhaps, let's call it current_webpacker_instance just to be clear, current_webpacker doesn't make sense. What do you think?
|
Any plans on merging this? |
|
Thanks @palkan 🙏 sorry it took me a while to merge |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1808.
Added docs on how to use Webpacker from Rails engine.