Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update yarn packages & update get_style_rule to handle css-loader@3.0.0 #2130

Merged
merged 1 commit into from
Sep 18, 2019
Merged

update yarn packages & update get_style_rule to handle css-loader@3.0.0 #2130

merged 1 commit into from
Sep 18, 2019

Conversation

mmaloon
Copy link
Contributor

@mmaloon mmaloon commented Jun 13, 2019

After upgrading css-loader to version 3, we get a build error from the CssLoader that there are invalid options. Turns out the localIdentName option needs to be nested within the modules option.

@mmaloon mmaloon mentioned this pull request Aug 14, 2019
Closed
@jakeNiemiec jakeNiemiec reopened this Aug 15, 2019
jakeNiemiec
jakeNiemiec approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@jakeNiemiec jakeNiemiec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terribly sorry, I had completely mixed up those 2 similar PRs.

I can confirm that there are no breaking changes in the listed updates (other than css-loader)

@gauravtiwari gauravtiwari merged commit 3c394fc into rails:master Sep 18, 2019
@indigolain indigolain mentioned this pull request Nov 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakeNiemiec jakeNiemiec jakeNiemiec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmaloon @jakeNiemiec @gauravtiwari