Remove "Nothing to do" log entry #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeNiemiec
requested changes
Dec 30, 2019
| @@ -27,7 +27,6 @@ def compile | |||
| record_compilation_digest | |||
| end | |||
| else | |||
There was a problem hiding this comment.
Suggested change
| else | |
| else | |
| logger.debug "Everything's up-to-date. Nothing to do" |
|
@reggieb This feels like a good change to me. Want to accept the requested change so we can try to get this through? |
|
@rossta I've reinstated the logger call with the level set to debug |
|
This would be very helpful to merge in when able! |
|
@jakeNiemiec Tagging to bring this to your attention. You'd be very popular if you found time to re-review and merge! |
|
Is there a reason why this has been closed without merging? |
|
Sorry @reggieb Was just trying to cleanup PRS and issues so we can look things afresh post 6.0 release. |
|
@gauravtiwari No problem. I'm really please this has finally been merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2392
Removes the "Nothing to do" log entry from the
Webpacker::Compiler#compilermethod.Nothing to do should include logging!