move browserslist and babel config into package.json #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipkayhil
force-pushed
the
use-package-json
branch
from
3cb8287 to
c22e754
Compare
|
@gauravtiwari any chance I could get some feedback on this? I really think it would be a beneficial change |
|
Thanks @skipkayhil looks great. I am sorry it took me a while to review. There is one config for react as well: https://github.com/rails/webpacker/blob/master/lib/install/examples/react/babel.config.js that we need to migrate to use package.json. |
skipkayhil
force-pushed
the
use-package-json
branch
2 times, most recently
from
687663a to
dc6c147
Compare
- running webpacker:install will now add browserslist and babel
configuration into package.json instead of copying files
- webpacker:install:react also updated to use preset in package.json
- use babel/preset.js in npm package as a preset, providing updates and
less complexity to apps
- babel/preset-react.js can be used for react applications
- additionally, updated rubocop.yml to target ruby 2.4 since it is now
the minimum supported version
skipkayhil
force-pushed
the
use-package-json
branch
from
dc6c147 to
6e9a96e
Compare
gauravtiwari
approved these changes
Aug 17, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running webpacker:install will now add browserslist and babel configuration into package.json instead of copying files. browserslist recommends using package.json key over rc file.
Use babel.config.js in npm package as a preset, providing updates and less complexity to apps. Fixes #2532 (at least partially)
Additionally, updated rubocop.yml to target ruby 2.4 since it is now the minimum supported version