Constrain supported node versions #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rails#2874 Until Webpacker uses node-sass 5.0+, node version 15 isn't supported.
|
I think there's been a misunderstanding here. Webpacker is compatible with Node 15, and the issue this was originally linked to was related to node-sass's use of node-gyp (which requires python to build native extensions for node-sass). Node-sass isn't on master anymore (see #2772). Sass support was also made optional in #2802, so any dart-related issues should be sidestepped by default too. The changeset I had in mind was more like this: gmcgibbon@310d3c6 I think we can add Node 15 to CI (simply because it is good to test webpacker under the latest Node) and revert this patch. |
gmcgibbon
added a commit
to gmcgibbon/webpacker
that referenced
this pull request
Jan 13, 2021
Node 15 is supported by webpacker, but node-sass is causing native build extension issues for users without Python in webpacker 5.x.
This was referenced Jan 13, 2021
Merged
gauravtiwari
pushed a commit
that referenced
this pull request
Jan 13, 2021
|
@gmcgibbon Thanks for the clarification and the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2874
Until Webpacker uses node-sass 5.0+, node version 15 isn't supported.