Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] build: bump node-sass from 4.13.0 to 6.0.1 #3217

Closed
wants to merge 1 commit into from

Conversation

pure-js
Copy link

@pure-js pure-js commented Nov 7, 2021

It's necessary for the latest Node.js LTS build (16.13.0) support.
In other case yarn install command will crash

@pure-js pure-js changed the title build: bump node-sass from 4.13.0 to 6.0.1 [4.x] build: bump node-sass from 4.13.0 to 6.0.1 Nov 7, 2021
@justin808
Copy link
Contributor

justin808 commented Nov 15, 2021

@pure-js why not just upgrade rails/webpacker?

@justin808
Copy link
Contributor

@guillaumebriday What is the policy on making updates to old branches? I think if the fix can be done by one's config, that's good enough, such as this one, using resolutions.

@pure-js You can use https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/ to set the version for node-sass for your project.

@guillaumebriday reopen if you see fit.

@ghiculescu
Copy link
Member

ghiculescu commented Dec 17, 2021

I think this is a bigger issue since https://devcenter.heroku.com/changelog-items/2306, for people still on webpacker 5 you can no longer deploy to Heroku without a lot of buildpack tinkering.

@justin808
Copy link
Contributor

Applications using the heroku/ruby buildpack that do not have a version of Node installed by another buildpack (such as the heroku/nodejs buildpack) will now receive:

Thus, you should use the heroku/nodejs buildpack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants