Use exist? instead of deprecated exists?
#3250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Dir.exists?` and `File.exists? were removed by ruby/ruby#5352. It will be the following error in Ruby 3.2. ```console % ruby -ve 'File.exists?("foo.rb")' ruby 3.2.0dev (2021-12-28T15:22:18Z master 39b3aa4fb3) [x86_64-darwin19] -e:1:in `<main>': undefined method `exists?' for File:Class (NoMethodError) File.exists?("foo.rb") ^^^^^^^^ Did you mean? exist? ``` And this PR enables `Lint/DeprecatedClassMethods` cop to detect these deprecated methods.
|
The build error is unrelated to this change. #3251 will solve it. |
amatsuda
pushed a commit
to amatsuda/webpacker
that referenced
this pull request
Jan 20, 2023
`Dir.exists?` and `File.exists? were removed by ruby/ruby#5352. It will be the following error in Ruby 3.2. ```console % ruby -ve 'File.exists?("foo.rb")' ruby 3.2.0dev (2021-12-28T15:22:18Z master 39b3aa4fb3) [x86_64-darwin19] -e:1:in `<main>': undefined method `exists?' for File:Class (NoMethodError) File.exists?("foo.rb") ^^^^^^^^ Did you mean? exist? ``` And this PR enables `Lint/DeprecatedClassMethods` cop to detect these deprecated methods.
amatsuda
pushed a commit
to amatsuda/webpacker
that referenced
this pull request
Jan 20, 2023
`Dir.exists?` and `File.exists? were removed by ruby/ruby#5352. It will be the following error in Ruby 3.2. ```console % ruby -ve 'File.exists?("foo.rb")' ruby 3.2.0dev (2021-12-28T15:22:18Z master 39b3aa4fb3) [x86_64-darwin19] -e:1:in `<main>': undefined method `exists?' for File:Class (NoMethodError) File.exists?("foo.rb") ^^^^^^^^ Did you mean? exist? ``` And this PR enables `Lint/DeprecatedClassMethods` cop to detect these deprecated methods.
byroot
added a commit
that referenced
this pull request
Jan 31, 2023
Backport #3250 to 5-x-stable branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dir.exists?and `File.exists? were removed by ruby/ruby#5352.It will be the following error in Ruby 3.2.
And this PR enables
Lint/DeprecatedClassMethodscop to detect these deprecated methods.