Skip to content

Conversation

@tristandunn
Copy link

@tristandunn tristandunn commented May 14, 2017

Once lazy compiling in #360 is released, these tasks will generate output in tests. This prevents it in the test environment.

@tristandunn tristandunn changed the title Allow silencing of task output. Silence task output in test environment. May 14, 2017
@guilleiguaran guilleiguaran requested a review from javan May 26, 2017 18:21
@gauravtiwari
Copy link
Member

@tristandunn Probably #539 might help with the output noise. What do you think?

@gauravtiwari
Copy link
Member

And sorry it took a while to review this one 😞

@javan
Copy link
Contributor

javan commented Jul 2, 2017

I'd prefer to see the current setup inverted. Move webpack command invocations to the lib so Webacker.compile doesn't need to call a rake task.

@dhh
Copy link
Member

dhh commented Aug 9, 2017

This is fixed via #627 👍

@dhh dhh closed this Aug 9, 2017
@tristandunn tristandunn deleted the td-clean-up-tasks branch August 9, 2017 20:12
@tristandunn
Copy link
Author

@dhh Thanks. Works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants