Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for webpacker being installed by having config file #677

Conversation

justin808
Copy link
Contributor

Previously checking for the bin stubs, but some frameworks, like React
on Rails, don't use the binstubs.

Previously checking for the bin stubs, but some frameworks, like React
on Rails, don't use the binstubs.
@justin808
Copy link
Contributor Author

@dhh @gauravtiwari this is the final change required by React on Rails.
See this comment from @gauravtiwari

@gauravtiwari
Copy link
Member

@justin808 It's already done here:

https://github.com/rails/webpacker/blob/master/lib/tasks/webpacker/verify_install.rake#L6

And the check_binstubs change was introduced here: #381

@justin808
Copy link
Contributor Author

@gauravtiwari Please try what you just said, by deleting the binstubs. You will see what I'm staying. The task depends on task verify_install: [:check_node, :check_yarn, :check_binstubs] do
so check_binstubs throws.

@gauravtiwari
Copy link
Member

@justin808 Yepp I know, thinking a way around this ;). The change introduced in this PR is already present in verify_install task.

@dhh
Copy link
Member

dhh commented Aug 21, 2017

I'm not sure I follow this. What's the point of using these tasks that depend on binstubs if they binstubs are not there? Why not just have an alternate set of tasks for React on Rails that doesn't have these preconditions?

@justin808
Copy link
Contributor Author

@dhh is right. I was trying to customize the compiler task in webpacker.yml to allow a custom task that would use nps or yarn. We can close this for now. The idea was that for non-js developers, compile could be set to true, and the JS would just work. However, on a giant project, the cost of checking for ever web request is too much.

@dhh dhh closed this Aug 21, 2017
@justin808 justin808 deleted the issue-464-merge-webpacker-lite-into-webpacker-v4 branch April 6, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants