Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontally scrolling tables in list view - pull request potential? #2272

Closed
sbull opened this issue Apr 27, 2015 · 9 comments
Closed

Horizontally scrolling tables in list view - pull request potential? #2272

sbull opened this issue Apr 27, 2015 · 9 comments

Comments

@sbull
Copy link
Contributor

sbull commented Apr 27, 2015

I recently worked out a way to make the "list" view tables more useful to me - showing more/all columns with horizontal scrolling and frozen header columns, as I described here: https://github.com/sferik/rails_admin/wiki/Horizontally-scrolling-table-with-frozen-columns-in-list-view
It's mostly done in javascript, but could be better suited to be integrated in the gem instead.

I'm wondering if there would be support for making this a configuration option. If the feature would likely be accepted, I'll work on a pull request for it. I'm sure I'll need some guidance along the way - such as naming for the config option, how to build a test case, etc. Should I take a crack at this, or do you think it's better to live in userland customization instead of in the gem?

@sbull
Copy link
Contributor Author

sbull commented Apr 28, 2015

@mshibuya do you have thoughts on this? Or should I discuss it with someone else? Thanks!

@iMacTia
Copy link

iMacTia commented Jul 19, 2015

It should definitely be included as an option for the gem, would make a lot of sense!

@SuperMasterBlasterLaser
Copy link
Contributor

@sbull I have used your javascript code, and that kind of result I have got:

1

It "destroys" table.

@sbull
Copy link
Contributor Author

sbull commented Nov 24, 2015

I've slightly updated the JS with rails_admin 0.6.8. Here's what I get (rails_admin 0.6.8, Chrome 46.0).

railsadminhorizscroll

@martnst
Copy link

martnst commented May 25, 2016

+1 on including it with rails_admin per default

@opensourceame
Copy link

+1 for including it with Rails but I think it should be optional in the config. The JS should also add some classes to the wrapper elements so it's easily to customise the look.

@twikah
Copy link

twikah commented Mar 20, 2018

+1 on including it with rails_admin as optional in the config!

sbull added a commit to sbull/rails_admin that referenced this issue Apr 29, 2018
…mns and frozen row headers instead of paginated sets

Addresses Issue railsadminteam#2272.
sbull added a commit to sbull/rails_admin that referenced this issue Apr 29, 2018
…mns and frozen row headers instead of paginated sets

Addresses Issue railsadminteam#2272.
sbull added a commit to sbull/rails_admin that referenced this issue Apr 29, 2018
…mns and frozen row headers instead of paginated sets

Addresses Issue railsadminteam#2272.
sbull added a commit to sbull/rails_admin that referenced this issue Apr 30, 2018
…mns and frozen row headers instead of paginated sets

Addresses Issue railsadminteam#2272.
sbull added a commit to sbull/rails_admin that referenced this issue May 1, 2018
…mns and frozen row headers instead of paginated sets

Addresses Issue railsadminteam#2272.
@sbull
Copy link
Contributor Author

sbull commented May 2, 2018

I have created PR #3017 to add this feature and updated the wiki with a new workaround.

sbull added a commit to sbull/rails_admin that referenced this issue May 19, 2018
…mns and frozen row headers instead of paginated sets

Addresses Issue railsadminteam#2272.
@mshibuya
Copy link
Member

mshibuya commented May 2, 2019

#3017 was merged in.

@mshibuya mshibuya closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants