Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveRecord csv export optimization. #1783

Merged
merged 1 commit into from
Oct 24, 2013
Merged

ActiveRecord csv export optimization. #1783

merged 1 commit into from
Oct 24, 2013

Conversation

oruen
Copy link
Contributor

@oruen oruen commented Oct 7, 2013

When dealing with large record sets with csv export Rails proccess could get stuck because of lots of objects being created in one moment. ActiveRecord find_in_batches method helps with this situation reducing the number of simultaneously instantiated objects.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) when pulling 725ab85 on oruen:optimize-csv-converter into 9a4d1ba on sferik:master.

mshibuya added a commit that referenced this pull request Oct 24, 2013
ActiveRecord csv export optimization.
@mshibuya mshibuya merged commit a70b2fe into railsadminteam:master Oct 24, 2013
@mshibuya mshibuya mentioned this pull request Oct 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants