Fix devise specs for :devise_scope compatibility #2311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devise 3.5.1 allows objects to specify their devise scope heartcombo/devise@4837bb0
So if we add
allow_any_instance_of(User).to receive(:respond_to?).and_return(true)
this will respondtrue
here: https://github.com/plataformatec/devise/blob/4837bb0a4e5a1ea00e732f48ee2acef90606a31e/lib/devise/mapping.rb#L34and the specs will fail.
Moreover, afaik,
respond_to?
should answer withtrue
orfalse
and this specis doing something else. I think it was supposed to
allow_any_instance_of(User).to receive(:email).and_return(nil)