Change: make browser validations configurable via DSL

[dalpo]

Add the ability to enable/disable html5 browser validations through:

RailsAdmin.config do |config|
  config.browser_validations = true
end

[dalpo]

I'm not able to reproduce the failure with mongoid...

[dalpo]

Actually, browser validations are generating a lot of javascript errors for has_many/has_one widget because the input fields are hidden.

For instance:

An invalid form control with name='' is not focusable.
An invalid form control with name='recipe[main_variant_attributes][variant_ingredients_attributes][1435052695601][quantity]' is not focusable.
An invalid form control with name='' is not focusable.
An invalid form control with name='recipe[main_variant_attributes][variant_ingredients_attributes][1435052695601][quantity]' is not focusable.

[dalpo]

@mshibuya Let me know what do you think about this PR 😉

[andreazaupa]

+1

[giacomomacri]

+1

[mshibuya]

I'm a bit concerned about defaulting this to false.
Don't you think that client-side validation is a nice-to-have feature?

[dalpo]

@mshibuya If you prefer I can set the default value to true. It's not a problem for me.

My personal opinion is that browser validation is a nice to have feature only for simple application's models.

In my experience there are two use cases that it could be a trouble:

• When a model has has_many/has_one nested attributes to be validated the browser-validation is generating a lot of js errors as commented above.
• When a model has conditional validations.

Let me know what do you prefer as default value so I can do a commit and rebase the PR 😉

[dalpo]

@mshibuya I changed the default value to true

[dalpo]

@mshibuya @sferik any news about this PR?

[mshibuya]

Squashed and cherry-picked with slight modification(html_required? is unnecessary, because setting novalidate to form is enough). Thanks!

[dalpo]

❤️

Thanks @mshibuya!!

[fmh]

@dalpo

in my case , config.browser_validations = false has no effect, and browser validation still works for me. cannot see novalidate attribute in field

[dalpo]

@fmh Thanks for reporting!

I fixed it here: #2373

[fmh]

now, it works, thx 👍

[vincentwoo]

@dalpo as you said, I am getting a bunch of the following js errors on rails_admin 0.7:

An invalid form control with name='' is not focusable.
An invalid form control with name='recipe[main_variant_attributes][variant_ingredients_attributes][1435052695601][quantity]' is not focusable.

This did not happen on 0.6.8. Disabling all browser validation feels like overkill. Did we figure out what was wrong in this case?

[dalpo]

@vincentwoo I didn't investigate too much about it.

Btw this was the old PR that introduced the required attribute:
https://github.com/sferik/rails_admin/pull/2170/files

As you can see that PR didn't introduce the required attribute for all input fields, but only for those that are using the _form_field.html.haml and _form_text.html.haml partials.

However with the latest changes, now the required attribute is present for every input field.
May be this could cause your errors.

P.S.
Sorry for my bad English..