Support for ActiveRecord:Enum using string columns #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiii
force-pushed
the
support-active-record-enum-string-columns
branch
from
2e30916
to
10bff49
Compare
This adds support for string-based enum columns.
There are no tests for the active_record_enum type. Now the integration tests at least test them implicitly
tiii
force-pushed
the
support-active-record-enum-string-columns
branch
from
10bff49
to
91bc566
Compare
|
Amazing, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveRecord::Enum supports storing values in string database columns. This behaviour is not yet described in the rails documentation, but recently a test case for it was added. (rails/rails@67c1719)
I did not add extra tests for it, since the active_record_enum Type has not been tested previously. I did however add ActiveRecord::Enum attributes (with and without string columns) to the test models, so the behaviour is at least tested implicitly.