Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing sass-rails with sassc-rails #3156

Merged
merged 8 commits into from
Jun 25, 2019
Merged

Replacing sass-rails with sassc-rails #3156

merged 8 commits into from
Jun 25, 2019

Conversation

MikeRogers0
Copy link
Contributor

@MikeRogers0 MikeRogers0 commented Jun 19, 2019

Following up for #3072

This replaces sass-rails with sassc-rails, as sass-rails is now just a wrapper for sassc-rails (as updated in rails/sass-rails#424 )

@MikeRogers0 MikeRogers0 marked this pull request as ready for review June 19, 2019 16:00
@MikeRogers0
Copy link
Contributor Author

MikeRogers0 commented Jun 19, 2019

It looks like CI is failing, but I'm seeing the same error locally in the master branch. @sferik can you shed some light on how I can fix? :)

@jasnow
Copy link

jasnow commented Jun 19, 2019

FYI: Change
s/10/11/ on line 44 and
s/20/21/ on line 45
in inspec/integration/basic/dashboard/rails_admin_basic_dashboard_spec.rb
makes my local build green. Now figure out why. My run line:

bundle exec rspec ./spec/integration/basic/dashboard/rails_admin_basic_dashboard_spec.rb:36

mshibuya added a commit that referenced this pull request Jun 20, 2019
@mshibuya
Copy link
Member

Failure was an timing issue, that spec fails during specific window of time in UTC.

@MikeRogers0
Copy link
Contributor Author

MikeRogers0 commented Jun 20, 2019

Thank you @mshibuya, that has fixed most the CI issues I was seeing :) Though there appear to be a coverage drop in Ruby: jruby-9.2.6.0 Gemfile: gemfiles/rails_5.2.gemfile CI_ORM=mongoid causing a failure :/

@mshibuya
Copy link
Member

Lowering coverage-threshold to 90.05 is acceptable, since this change should not harm test exhaustivity.

@MikeRogers0
Copy link
Contributor Author

MikeRogers0 commented Jun 24, 2019

@mshibuya Minimum coverage updated 👍 :)

@MikeRogers0
Copy link
Contributor Author

Yay all green 🎊

@mshibuya mshibuya merged commit 63b9bff into railsadminteam:master Jun 25, 2019
@mshibuya
Copy link
Member

Merged in, thanks ❤️

@MikeRogers0 MikeRogers0 deleted the feature/switch-to-sassc-rails branch June 25, 2019 07:16
@jjjcheetah jjjcheetah mentioned this pull request Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants