-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing sass-rails with sassc-rails #3156
Replacing sass-rails with sassc-rails #3156
Conversation
It looks like CI is failing, but I'm seeing the same error locally in the |
FYI: Change
|
Failure was an timing issue, that spec fails during specific window of time in UTC. |
Thank you @mshibuya, that has fixed most the CI issues I was seeing :) Though there appear to be a coverage drop in |
Lowering coverage-threshold to 90.05 is acceptable, since this change should not harm test exhaustivity. |
@mshibuya Minimum coverage updated 👍 :) |
Yay all green 🎊 |
Merged in, thanks ❤️ |
Following up for #3072
This replaces
sass-rails
withsassc-rails
, assass-rails
is now just a wrapper forsassc-rails
(as updated in rails/sass-rails#424 )