-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3111: Convert CoffeeScript to JavaScript #3168
Conversation
Using CoffeeScript 1.12.2
Remove unnecessary return statements and other CoffeeScript sillyness
Using CoffeeScript 1.12.2
Remove unnecessary return statements and other CoffeeScript sillyness
Using CoffeeScript 1.12.2
Remove unnecessary return statements and other CoffeeScript sillyness
Using CoffeeScript 1.12.2
Remove unnecessary return statements and other CoffeeScript sillyness
Using CoffeeScript 1.12.2
Remove unnecessary return statements and other CoffeeScript sillyness
The build failure in 1 build target is:
No other target fails. |
When this has been merged, we can work on the CodeClimate issues presented – or do you want them to be handled in this same PR, @mshibuya ? |
We can work on the issues later, thanks for the PR! |
This PR is a solution for #3111, it does a few things:
.coffee
to.js
using CoffeeScript 1.12.2, which is the same version ascoffee-rails
is using (coffee-rails
=>coffee-script
=>coffee-script-source
)coffee-rails
Customisations in
custom/ui.coffee
in userland will have to be converted to ``custom/ui.js` by users.Using
decaffeinate
was not possible, as the converted files would cause therails_admin
tests to fail (most likely due to it outputting ES6, and the Capybara tests using PhantomJS, which barely supports ES5).