Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3376: Polymorphic associations don't work with namespaced classes #3377

Conversation

jacob-carlborg-apoex
Copy link
Contributor

No description provided.

@jacob-carlborg-apoex jacob-carlborg-apoex force-pushed the namespaced-class-polymorphic-association-3376 branch from 063ad0e to 2039f0a Compare August 12, 2021 12:53
@mshibuya
Copy link
Member

To make mongoid builds pass, you need to add the models for mongoid as well.

@jacob-carlborg-apoex jacob-carlborg-apoex force-pushed the namespaced-class-polymorphic-association-3376 branch from 2039f0a to 734a107 Compare August 17, 2021 13:52
@jacob-carlborg-apoex
Copy link
Contributor Author

I'll give that a try.

@jacob-carlborg-apoex jacob-carlborg-apoex force-pushed the namespaced-class-polymorphic-association-3376 branch from 734a107 to 1e122cd Compare August 17, 2021 14:28
@mshibuya mshibuya merged commit 74c61d4 into railsadminteam:master Aug 18, 2021
@mshibuya
Copy link
Member

Amazing job, thanks!

@jacob-carlborg-apoex
Copy link
Contributor Author

Thanks.

@jacob-carlborg-apoex jacob-carlborg-apoex deleted the namespaced-class-polymorphic-association-3376 branch August 18, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants