Add HTML5 validation for float-like field types #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are currently rendered as text inputs (the default). ref: https://www.w3.org/TR/2012/WD-html5-20121025/common-input-element-attributes.html#attr-input-step
Addresses issues raised by CodeClimate in https://codeclimate.com/github/sferik/rails_admin/pull/3378 and further consolidates a shared base field config for numeric types
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
floatanddecimalfields currently render as text inputs, allowing non-numerical values in the form.This updates their respective form helper to be the appropriate field type (number), as well as the
stephtml attribute to the most permissive for input validation.Closes #3289