Update Boolean pretty_value to include default fallback
#3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent the interface from breaking in the event a value is not correctly matched as 'true' or 'false'
|
Could you write a spec for this? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to reproduce the 🐛 seen on #1852 on recent versions of
mongoid/MongoDB(issue referencesmongoidv4, which was released roughly 7 years ago), so this may already be resolved in more recent versions of related dependencies.However, this change will at least prevent the interface from breaking in the event a boolean value doesn't match the explicit types checked in the
casestatement (closes #1852).There's a related Rubocop cop that would flag the missing
elsehere as well (this cop is disabled by default).