Remove unnecessary JavaScript dependency jquery.migrate.js #3389
Conversation
The frontend JavaScript code is not using any jQuery API that requires these compatibility shims. By removing the dependency we slightly reduce the compiled asset size and work towards reducing overall jQuery usage. Refs railsadminteam#2893
How did you figure this out? It would be possible but I want to be careful since we have very limited test code coverage for JS logics... |
Good question. I installed this PR branch in my local project and clicked around as much as possible and looked for JavaScript console errors. There were none. Additionally, I visually scanned the JavaScript code for known incompatibilities, I did not find any. But I agree, this is not foolproof and there is still a possibility of bugs. If you find any or already know of some, please let me know and I'll spend some time fixing them. If there are no known bugs, we basically have two options:
Without eventually taking the plunge, I'm not sure of a good strategy for dropping the shim. If you decide the risk isn't worth it, no hard feelings. Please feel free to close. |
|
OK, I trust you 😃 |
due to the behavior change in jQuery 3.0 https://jquery.com/upgrade-guide/3.0/#breaking-change-removeattr-no-longer-sets-properties-to-false Refs. #3389
due to the behavior change in jQuery 3.0 https://jquery.com/upgrade-guide/3.0/#breaking-change-removeattr-no-longer-sets-properties-to-false Refs. #3389
due to the behavior change in jQuery 3.0 https://jquery.com/upgrade-guide/3.0/#breaking-change-removeattr-no-longer-sets-properties-to-false Refs. #3389
due to the behavior change in jQuery 3.0 https://jquery.com/upgrade-guide/3.0/#breaking-change-removeattr-no-longer-sets-properties-to-false Refs. #3389
The frontend JavaScript code is not using any jQuery API that requires
these compatibility shims. By removing the dependency we slightly reduce
the compiled asset size and work towards reducing overall jQuery usage.
Refs #2893