✨ Add target_window to actions #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdufresne @mshibuya not sure why I'm marked as a first time contributor, but anyway, can you guys check this please ? |
jdufresne
reviewed
Nov 16, 2021
|
@jdufresne I've added a test, however, I'm not able to install |
mshibuya
reviewed
Nov 28, 2021
mshibuya
reviewed
Nov 28, 2021
mshibuya
reviewed
Nov 28, 2021
|
Changes unknown |
Co-authored-by: Mitsuhiro Shibuya <mit.shibuya@gmail.com>
|
Merged in, thanks for the contribution 🙌 |
|
Can we have this back ported and release on version 2.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to change the target window of the action.
For example, I want to open an
Importpage in a different window, I'll need to do:target_window :_blank