Allow middleware that extends ActionDispatch::Session::AbstractSecureStore #3462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to version 0.11.4 of
redis-session-store
, our application started failing to initialize due to the middleware check inrails_admin
.The failure is due to the security fix in
redis-session-store
that changes the middleware to inherit fromActionDispatch::Session::AbstractSecureStore
instead ofActionDispatch::Session::AbstractStore
.This PR simply changes the check in
engine.rb
to also allow middlewares that inherit fromActionDispatch::Session::AbstractSecureStore
.Would love to get this in the next 3.x beta.