Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow middleware that extends ActionDispatch::Session::AbstractSecureStore #3462

Merged

Conversation

ajkerr
Copy link
Contributor

@ajkerr ajkerr commented Jan 31, 2022

After upgrading to version 0.11.4 of redis-session-store, our application started failing to initialize due to the middleware check in rails_admin.

The failure is due to the security fix in redis-session-store that changes the middleware to inherit from ActionDispatch::Session::AbstractSecureStore instead of ActionDispatch::Session::AbstractStore.

This PR simply changes the check in engine.rb to also allow middlewares that inherit from ActionDispatch::Session::AbstractSecureStore.

Would love to get this in the next 3.x beta.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1772961639

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 95.635%

Files with Coverage Reduction New Missed Lines %
app/controllers/rails_admin/application_controller.rb 1 97.78%
Totals Coverage Status
Change from base Build 1765294698: -0.03%
Covered Lines: 3637
Relevant Lines: 3803

💛 - Coveralls

@mshibuya mshibuya merged commit 8abea83 into railsadminteam:master Jan 31, 2022
@mshibuya
Copy link
Member

Makes sense, thanks!

@ajkerr ajkerr deleted the check-for-abstract-secure-store branch January 31, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants