Fix dart sass 2.0 division deprecations #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The src/rails_admin/styles/base/theming.scss used division calculations which causes deprecation warnings with dart sass >= 2. The fontawesome-free version also has the same problem. Using calc() around the division math fixes the issue in theming.scss Upgrading fontawesome-free to the latest version fixies their issue
|
Changes unknown |
codealchemy
approved these changes
Jul 15, 2022
|
@mshibuya yeah I can update those today 😄 |
Fontawesome-free removed eot, svg and woff files and do not seem to be included anymore
|
Thanks for fixing this. |
|
Thank you 🌟 |
mshibuya
added a commit
that referenced
this pull request
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
src/rails_admin/styles/base/theming.scssused division calculations which causes deprecation warnings with dart sass >= 2.The fontawesome-free version also has the same problem.
Using calc() around the division math fixes the issue in theming.scss
Upgrading fontawesome-free to the latest version fixes their issues
sass/sass#2565
sass/dart-sass#663
For rails projects using sassc this is a problem. The app I currently work on is on most recent gems and packages for everything. We do a really good job at keeping everything up to date. Unfortunately these warnings have now turned into errors being raised in
webpacker-dev-server.I tested these changes by publishing my own npm package while pointing our
Gemfileto my forked version.If we could get a minor release with this and any other minor fixes that may be in that would be really appreciated 😄