case-insensitive gem search #107
Conversation
| @@ -21,3 +21,6 @@ storage | |||
| tmp | |||
|
|
|||
| public/sitemap.xml.gz | |||
|
|
|||
| app/assets/builds | |||
| public/assets | |||
There was a problem hiding this comment.
These were generated locally but not ignored. I assume they should be.
| 4. Go to http://localhost:3000 | ||
| 3. `rake data:find_or_create_rails_releases` | ||
| 4. `foreman start -f Procfile.dev` | ||
| 5. Go to http://localhost:3000 |
There was a problem hiding this comment.
Needed this extra step to get the app up and running
| @@ -1,40 +1,42 @@ | |||
| require "fog-aws" | |||
| unless Rails.env.local? | |||
There was a problem hiding this comment.
This is a bit brute force, but loading this caused errors locally that can be ignored, I think, if we don't want to connect to AWS in development. I can take it out if you like, but this prevents local dev from running without AWS keys. The only change is the guard clause, the rest is whitespace.
| @@ -6,7 +6,7 @@ def create | |||
| if name == "rails" | |||
| RailsReleases::Create.perform_async params.fetch(:version) | |||
| else | |||
| Gemmy.find_by(name: name)&.then { | |||
| Gemmy.find_by_name(name)&.then { | |||
There was a problem hiding this comment.
I did a global search and replace for find_by!?(name:...
|
|
||
| def self.find_by_name!(name) | ||
| find_by_name(name, raise_error: true) | ||
| end |
There was a problem hiding this comment.
...and added these two methods for case-insensitive search.
The other option of course would be to change the data type to citext, which requires a postgres extension. I think that would be cleaner but didn't want to go quite that far.
Fixes #106. Review with "hide whitespace" please. Love the app, wasn't aware of it before your LinkedIn post. Thanks!