Skip to content

Commit

Permalink
[CPL-16235] Fetch data by specified date columns only
Browse files Browse the repository at this point in the history
Commits 2597485 and
d880663 accidentally
reverted to original tap-google-ads behaviour in which
tap fetches all reports day-by-day ONLY no matter
whether `date` column is requested in the config or not.

The tap must fetch data by months if `month` column
specified but `date` column is not.

The tap must fetch data by days if both `month` and
`date` columns are specified.
  • Loading branch information
nikitamaruniak committed Aug 13, 2024
1 parent 7e5d679 commit 36486d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tap_google_ads/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ def build_stream_metadata(self):
# Add inclusion metadata
if self.behavior[report_field]:
inclusion = "available"
if transformed_field_name in ({"date"} | self.automatic_keys):
if transformed_field_name in self.automatic_keys:
inclusion = "automatic"
else:
inclusion = "unsupported"
Expand Down

0 comments on commit 36486d2

Please sign in to comment.