This repository has been archived by the owner on May 21, 2019. It is now read-only.
Updates package script to run gulp build before electron-packager #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
vlad-shatskyi
added a commit
that referenced
this pull request
Sep 29, 2015
Updates package script to run gulp build before electron-packager
|
@chaseadamsio, thank you for the contribution. |
|
👍 |
|
👍 happy to contribute to something that displaces the antiquated tools we have to deal with now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing a solution for #32.
It seems like the tasks for compiling
typescript,reactandsassisn't run beforenpm run package, which is what's causing this issue, if you haven't runnpm startyet.This is a possible scenario that works.
@luizkowalski @jbaskeen @mzgnr