Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melissa/log 779 variables love #373

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Conversation

melissa-hale
Copy link
Contributor

reworked a lot of the variables page with the intent to make it easier to understand overall maintenance, and particular attention to reference variables.

Copy link

linear bot commented Nov 9, 2023

LOG-779 Variables & Reference Variables

Brody raised this. People have difficulty using variables

https://discord.com/channels/713503345364697088/880575219541114940/1156605062097948713

CleanShot 2023-10-18 at 12.55.362x.png

Get Brody to review since he spends a lot of time explaining

https://docs.railway.app/develop/variables


Also address these

  • FLOW - distinction between reference/templated variables
  • FLOW - Types of variables should be made more clear
    • Defining
    • Types
      • Railway specific
        • Git
        • User-provided
      • Reference Variables
      • Service Discovery
  • INCORRECT remove reference to Plugin Variables (LEAVE UNTIL PLUGINS ARE GONE)

Copy link

railway-app bot commented Nov 9, 2023

This PR is being deployed to Railway 🚅

Copy link

railway-app bot commented Nov 9, 2023

This PR is being deployed to Railway 🚅

🔎 meilisearch: ◻️ REMOVED
📚 railway docs: ◻️ REMOVED

Copy link
Contributor

@JakeCooper JakeCooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bones are excellent

Proposed a bit of re-ordering due to the way that I personally would think about "growing my usage" of variables on railway (single variables, references, shared using references, railway provided using references)

src/docs/develop/variables.md Outdated Show resolved Hide resolved
src/docs/develop/variables.md Outdated Show resolved Hide resolved
@melissa-hale
Copy link
Contributor Author

Thanks @JakeCooper ! super helpful feedback. I think it's a lot better now

src/docs/develop/variables.md Show resolved Hide resolved
src/docs/develop/variables.md Outdated Show resolved Hide resolved
@melissa-hale melissa-hale merged commit 7bd9ad6 into main Nov 10, 2023
1 check passed
@melissa-hale melissa-hale deleted the melissa/LOG-779-variables-love branch November 10, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants